Cleanup clipboard interop and add tests#1950
Merged
RussKie merged 3 commits intodotnet:masterfrom Sep 24, 2019
Merged
Conversation
11a0141 to
2efa698
Compare
2efa698 to
6ca980c
Compare
JeremyKuhne
reviewed
Sep 20, 2019
Member
|
How does this fix #1951? |
2e06a8f to
2bc76b2
Compare
2bc76b2 to
13c624b
Compare
Contributor
Author
Now pushed that commit :) |
Codecov Report
@@ Coverage Diff @@
## master #1950 +/- ##
===================================================
+ Coverage 26.93408% 27.24692% +0.31284%
===================================================
Files 864 864
Lines 266755 266709 -46
Branches 37915 37910 -5
===================================================
+ Hits 71848 72670 +822
+ Misses 189788 188867 -921
- Partials 5119 5172 +53
|
JeremyKuhne
approved these changes
Sep 20, 2019
RussKie
reviewed
Sep 24, 2019
|
|
||
| namespace System.Windows.Forms.Tests | ||
| { | ||
| public class ClipboardTests |
Contributor
There was a problem hiding this comment.
Just FYI, there can be concurrency issues with testing static clipboard singleton.
We had discussions some months ago about it - #416 (comment)
RussKie
approved these changes
Sep 24, 2019
Contributor
Do we need to patch 3.1? |
Contributor
Author
I would say so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Microsoft Reviewers: Open in CodeFlow