Merged
Conversation
A typed theory data object is used in the test for building the apps configuration.
The test now uses a typed theory data object for the configuration generator tests.
A typed TheoryData Obejct is now used to pass in parameters to the Font converter test.
…winforms into Tests_should_use_TheoryData
using type instead of var
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11441 +/- ##
===================================================
+ Coverage 73.44664% 74.33994% +0.89329%
===================================================
Files 3098 3028 -70
Lines 632225 627403 -4822
Branches 46653 46770 +117
===================================================
+ Hits 464348 466411 +2063
+ Misses 164485 157642 -6843
+ Partials 3392 3350 -42
Flags with carried forward coverage won't be shown. Click here to find out more. |
...harp/tests/UnitTests/System/Windows/Forms/Generators/ProjectFileReaderTests.FontConverter.cs
Outdated
Show resolved
Hide resolved
…rTests.FontConverter.cs
Tanya-Solyanik
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes progress to fix #11041
Deal with the feedback of the PR #11171
Proposed changes
for the file reader font converter.
Customer Impact
Regression?
Risk
-There should be no risk in moving to strongly typed parameterized test methods.
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow