Conversation
RussKie
left a comment
There was a problem hiding this comment.
Top job!
I glanced over the tests, for the most part they looked good with exception for the comment I left about arrangements.
I'll need more time to go though all 3.5K lines code in greater details.
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/TreeViewTests.cs
Show resolved
Hide resolved
|
@RussKie I see you are a committer now - great! I'll let you own this one then 😺 |
|
Do you wish squash yourself or me to squash-merge? |
| [InlineData(1, 15)] | ||
| [InlineData(2, 15)] | ||
| [InlineData(5, 15)] | ||
| [InlineData(6, 15)] |
|
It looks like debug and release builds yield different results... This is wwird |
|
Any idea why that would be the case? Maybe it depends on the machine? |
|
Not quite sure at this stage. I will have to dig deeper into it. |
|
When running the tests locally, debug (.\build -test) fails while release (.\build -test -configuration Release) passes. I didn't step through the code, but it's reproable locally. @hughbe can you please try to step through in debug and see what you find? Thanks :) |
|
Great! I fixed the tests :) |
|
@hughbe the fixes seem to weaken the tests significantly, as it no longer tests that the user provided values are preserved. I see that its probably happening outside the WinForms codebase in the native control, but do you have any explanation why |

No description provided.