Setting `ListView.CheckBoxes` after `ListView.StateImageList` destroys imagelist

[RussKie]

• Have you experienced this same bug with .NET Framework?: Yes

Problem description:

An outcome of investigations in #3358, in the following scenarios CheckBoxes is toggled whilst a user-supplied imagelist is bound to StateImageList property - the native listview control will tarnish the user-supplied one.

The issue is reproducible in net4x and netcore3.1.

ListView.CheckBoxes=false

ListView.CheckBoxes=true

Additionally, it appears changes in one instance of listview may affect another, if state imagelist were similar (e.g. contain the same set of images), as the native layer may be caching.

Changes to the 2nd listview after tarnishing the first


Expected behavior:

Changes CheckBoxes property does no affect a user-supplied imagelist.

Minimal repro:

https://github.com/RussKie/ListViewCheckboxesStateImageList

Also the issue is easily reproducible in .NET Framework designer by setting up the StateImageList property on a ListView control, (save), and then setting CheckBoxes=true.

[weltkante]

#3601 disabled image list sharing here as a workaround so the issue cannot be reproduced in current master, but that doesn't mean it shouldn't be fixed. The workaround to avoid random crashes comes at cost of making agressive duplicates of image lists so its worth keeping this open and implementing ownership rules around shared image lists correctly.

Image list sharing can and should be reenabled again, but this requires looking at the native control source to understand what assumptions it makes about ownership when e.g. switching checked mode on. The previous implementation tried to do this but apparently failed and was broken.

[weltkante]

If #3601 ends up being reverted as part of #4169 this needs to be reprioritized since it now again is an active bug that can be triggered by wrong call order.

[edit] the revert was moved to a different PR, #4277, comment above still applies accordingly