Skip to content

Source-build cannot override MicrosoftNetCompilersToolsetPackageVersion property #3392

@NikolaMilosavljevic

Description

@NikolaMilosavljevic

Source-build, that uses Preview 3 toolset SDK, cannot override MicrosoftNetCompilersToolsetPackageVersion property. This was caused by Preview 3 toolset SDK setting this property in Microsoft.NETCoreSdk.BundledVersions.props file due to dotnet/installer@3ca0db8. That issue was later fixed with dotnet/installer@38be1b1, in Preview 4.

A solution for this issue is to use MicrosoftNetCompilersToolsetVersion property in the following places:
https://github.com/dotnet/sdk/blob/f23aa760569111e3d80ec0501bb14f076548025b/src/Layout/redist/targets/GenerateLayout.targets#L30
https://github.com/dotnet/sdk/blob/f23aa760569111e3d80ec0501bb14f076548025b/src/Layout/redist/redist.csproj#L36
https://github.com/dotnet/sdk/blob/f23aa760569111e3d80ec0501bb14f076548025b/src/Layout/redist/redist.csproj#L37

Temporary solution is being implemented as a patch for sdk repo - https://github.com/dotnet/installer/blob/main/src/SourceBuild/patches/sdk/0002-Use-MicrosoftNetCompilersToolsetVersion-instead-of-M.patch

After Preview 4 ships, toolset SDK will be updated to a build that contains the fix, and this temporary solution can be reverted.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-patch-removalRemoving patches for contributing repos from source-build

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions