Delete analyzers from 9.0 targeting packs#1099
Merged
mthalman merged 3 commits intodotnet:mainfrom Dec 16, 2024
Merged
Conversation
README.md
Outdated
| Generating new targeting packages is not supported. No new targeting packs should be needed/added. If you feel | ||
| a new targeting pack is needed, please [open a new issue](#filing-issues) to discuss. | ||
|
|
||
| When adding targeting packs, the `analyzers` directory should be excluded. |
Member
There was a problem hiding this comment.
I think this would be better added to https://dev.azure.com/dnceng/internal/_git/dotnet-source-build-utilities?path=/IlGenerator/README.md. I likely wouldn't see/remember this here whereas I always have to refer to the source-build-utilities readme.
MichaelSimons
approved these changes
Dec 16, 2024
Member
MichaelSimons
left a comment
There was a problem hiding this comment.
One doc suggestion. Core changes LGTM
MichaelSimons
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzers should be excluded from the targeting packs. See dotnet/sdk#45435 (comment). Confirmed that this was already done for the 8.0 targeting packs.