Remove feature flag for transitive #: directives#54012
Merged
jjonescz merged 2 commits intoApr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the feature-flag gating for processing transitive file-level #: directives in file-based programs, aligning implementation, tests, and docs with the new default behavior.
Changes:
- Stop checking
ExperimentalFileBasedProgramEnableTransitiveDirectiveswhen validating directives (transitive directives always allowed). - Update
dotnet run filetests to no longer set the transitive-directives flag and remove the flag-specific test. - Remove the flag constant from the FileBasedPrograms internal API surface and update documentation accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Removes transitive-directive flag setup and deletes the test that asserted the flag gating behavior. |
| src/Microsoft.DotNet.ProjectTools/VirtualProjectBuilder.cs | Removes the runtime check that required the transitive-directives flag for non-entry-point directives. |
| src/Cli/Microsoft.DotNet.FileBasedPrograms/InternalAPI.Unshipped.txt | Drops the internal API entry for the removed flag constant. |
| src/Cli/Microsoft.DotNet.FileBasedPrograms/FileLevelDirectiveHelpers.cs | Removes the transitive-directives flag constant from CSharpDirective.IncludeOrExclude. |
| documentation/general/dotnet-run-file.md | Removes documentation that stated transitive directives were gated behind a feature flag. |
Member
|
Are we going to get this into 10.0.300 as well? |
Member
Author
|
IIRC, code complete of 10.0.3xx was yesterday. Also the IDE integration is probably not even released yet. |
Member
|
We should check on the code complete status and if there's a process for getting changes in still. On the IDE side they release far more often and the experience in the insiders and pre-release versions is already good and we can do follow ups to tweak the experience as needed. Is the opt-in flag for transitive directives removed for .NET 11 already? |
Member
Author
No, but this PR will flow there once merged. |
RikkiGibson
approved these changes
Apr 21, 2026
333fred
approved these changes
Apr 21, 2026
Member
Author
|
/backport to release/10.0.3xx |
Contributor
|
Started backporting to |
rkttu
added a commit
to rkttu/cadenza
that referenced
this pull request
May 28, 2026
Two scripting ergonomics improvements that show up across every
Cadenza SDK variant.
`Env.ScriptPath` / `Env.ScriptDirectory` (src/core/Env.cs)
Read the entry .cs file's absolute path from inside the running
program. Backed by `AppContext.GetData("EntryPointFilePath")` /
`EntryPointFileDirectoryPath`, which the .NET 10 file-based CLI
injects as `RuntimeHostConfigurationOption` items on every
`dotnet run`/`dotnet build`. Both return null after
`dotnet publish` (the CLI strips those entries when the binary
is no longer the script) — documented in the doc comments and
the skill's gotcha list.
`ExperimentalFileBasedProgramEnableTransitiveDirectives=true`
Defaulted in all five Sdk.props (Cadenza, Cadenza.Worker,
Cadenza.Web, Cadenza.Mcp, Cadenza.Agent). Without this, a
`#:package` / `#:property` / nested `#:include` inside an
`#:include`d helper file is silently dropped by the directive
preprocessor — verified empirically before shipping by
reproducing the failure with a vanilla SDK and the success once
the property lands in Sdk.props. The flag is read AFTER our
Sdk.props is imported into the synthesized csproj, so it works
from there despite the directive parsing happening pre-MSBuild.
Slated for removal once PR dotnet/sdk#54012 (transitive
directives always-on) reaches the released SDK.
Family bump 1.0.14 -> 1.0.15.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #53775 (comment).