Add implicit reference to Microsoft.AspNetCore.App.Internal.Assets#44997
Add implicit reference to Microsoft.AspNetCore.App.Internal.Assets#44997MackinnonBuck merged 1 commit intomainfrom
Microsoft.AspNetCore.App.Internal.Assets#44997Conversation
|
Tested locally by building a local version of the SDK, manually making changes to the generated |
| <KnownAspNetCorePack Include="Microsoft.AspNetCore.App.Internal.Assets" | ||
| TargetFramework="net10.0" | ||
| AspNetCorePackVersion="$(MicrosoftAspNetCoreAppRuntimePackageVersion)" /> | ||
|
|
There was a problem hiding this comment.
This is the only part I'm not 100% sure about. You can have an SDK and multiple runtimes. Meaning that you can have an install that has 1.0.0, 1.0.1, and 1.0.2 installed. 1.0.2 might be bundled, but your app might be using <FrameworkReference="Microsoft.AspNetCore.App" Version="1.0.0" /> or have it pinned in the global.json.
In that case shouldn't we respect that?
@maraf do you have any thoughts?
There was a problem hiding this comment.
My understanding is that when we are building an app, we are always using the bundled versions; otherwise the rest of the items wouldn't work correctly as well.
There was a problem hiding this comment.
@maraf but it depends on whether you are pinning explicitly to a previous runtime, isn't it?
Follow up to dotnet/aspnetcore#58721