Fix workload install or update with workload set specified in global.json#41983
Merged
dsplaisted merged 3 commits intoJul 7, 2024
Merged
Conversation
Forgind
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where if a workload set was specified in global.json, and that workload set wasn't installed, then workload install and update commands would fail. This was because the process to write install records for VS workloads depended on having valid manifests. Fixed this by moving the process to write install records to after manifests are updated.
Also updated VM tests to be able to install additional .NET runtimes, which should allow us to continue to use the same baseline installer and workload set versions over time.