Add MetadataUpdaterSupport property#18670
Merged
sbomer merged 1 commit intodotnet:mainfrom Jul 1, 2021
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
eerhardt
approved these changes
Jul 1, 2021
Member
eerhardt
left a comment
There was a problem hiding this comment.
Looks good. Thanks for catching this and adding it.
LakshanF
approved these changes
Jul 1, 2021
Contributor
LakshanF
left a comment
There was a problem hiding this comment.
Thanks for adding the COM and native host properties to this test as well. I'm a little confused with the difference between this test and GivenThatWeWantToRunILLink and am happy you are covering this one.
Member
Author
|
I think this test is supposed to cover all RuntimeHostConfigurationOptions, whether trim-enabled or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing some docs I noticed that the feature switch added in dotnet/runtime#54590 hadn't been defined in the SDK yet. Also adds some existing switches to the test.