Skip to content

[release/5.0-RC2] Set DOTNET_ROOT in VSTestForwardingApp#13650

Merged
ViktorHofer merged 1 commit into
dotnet:release/5.0.1xx-rc2from
ViktorHofer:VSTEstFixPort50RC2
Sep 16, 2020
Merged

[release/5.0-RC2] Set DOTNET_ROOT in VSTestForwardingApp#13650
ViktorHofer merged 1 commit into
dotnet:release/5.0.1xx-rc2from
ViktorHofer:VSTEstFixPort50RC2

Conversation

@ViktorHofer

Copy link
Copy Markdown
Member

Cherry-pick of dd138ea

* Set DOTNET_ROOT in VSTestForwardingApp

When invoking dotnet test on an assembly, DOTNET_ROOT isn't set and
the testhost will fail to find a matching shared framework. This only
happens on Windows as the apphost feature is used there to differentiate
between x86 and x64.

* Add tests

* Reuse GetRootVariable

Co-authored-by: nohwnd <me@jakubjares.com>
@ViktorHofer ViktorHofer requested a review from nohwnd September 16, 2020 19:08
@ViktorHofer ViktorHofer self-assigned this Sep 16, 2020
@ViktorHofer ViktorHofer changed the base branch from master to release/5.0.1xx-rc2 September 16, 2020 19:08
@ViktorHofer ViktorHofer merged commit 3baa86d into dotnet:release/5.0.1xx-rc2 Sep 16, 2020
@ViktorHofer ViktorHofer deleted the VSTEstFixPort50RC2 branch September 16, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants