`dotnet workload install` prints NRE

[jonathanpeppers]

Using .NET 6.0.100-preview.4.21253.14:

> dotnet workload install microsoft-android-sdk-full --configfile NuGet.config

The command "works", in that everything is installed, but it prints an error at the end and gives a failing exit code:

Garbage collecting for SDK feature bands 6.0.100...
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.DotNet.Workloads.Workload.Install.NetSdkManagedInstaller.IsSingleFilePack(PackInfo packInfo) in dotnet.dll:token 0x60001c9+0x0
   at Microsoft.DotNet.Workloads.Workload.Install.NetSdkManagedInstaller.PackIsInstalled(PackInfo packInfo) in dotnet.dll:token 0x60001c3+0x0
   at Microsoft.DotNet.Workloads.Workload.Install.NetSdkManagedInstaller.DeletePack(PackInfo packInfo) in dotnet.dll:token 0x60001c4+0x0
   at Microsoft.DotNet.Workloads.Workload.Install.NetSdkManagedInstaller.GarbageCollectInstalledWorkloadPacks() in dotnet.dll:token 0x60001c0+0x151
   at Microsoft.DotNet.Workloads.Workload.Install.WorkloadInstallCommand.InstallWorkloads(IEnumerable`1 workloadIds, Boolean skipManifestUpdate) in dotnet.dll:token 0x60001ce+0x81
   at Microsoft.DotNet.Workloads.Workload.Install.WorkloadInstallCommand.Execute() in dotnet.dll:token 0x60001cb+0x216
   at Microsoft.DotNet.Cli.DotNetTopLevelCommandBase.RunCommand(String[] args) in dotnet.dll:token 0x60008af+0x5e
   at Microsoft.DotNet.Workloads.Workload.WorkloadCommand.Run(String[] args) in dotnet.dll:token 0x6000145+0x6
   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, TimeSpan startupTime, ITelemetry telemetryClient) in dotnet.dll:token 0x6000918+0x2e8
   at Microsoft.DotNet.Cli.Program.Main(String[] args) in dotnet.dll:token 0x6000916+0x6f

Even though this error appeared, I can build/deploy/run Android projects. So this must be something going wrong at the very end of workload install.

Full log: log.txt

Config file was: https://github.com/dotnet/net6-mobile-samples/blob/ad4980b9f818486106842fd596f6bc59e6963f9f/NuGet.config

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[sfoslund]

@jonathanpeppers did you repro this with the normal baseline manifest or did you alter the manifest at all?

[jonathanpeppers]

I updated the manifests with these manually: 6.0.100.zip

These should be the same as: dotnet/installer#10479

[sfoslund]

I don't think it's the cause of the bug, but is it purposeful that the manifest version was not updated? It looks like it's still version 5, the same as the previous manifest.

[jonathanpeppers]

I fixed the version going forward in: dotnet/android#5898

I'm still working on the xamarin-macios side of this, but we should have everything lined up better in preview 5.

[sfoslund]

@jonathanpeppers I'm not able to repro this with our main branch. When you run into this issue are you installing off of a clean SDK or do you already have other workloads installed? Is it reproing consistently for you?

[jonathanpeppers]

I just tried:

• Uninstall my system's .NET 6
• Manually delete any files left behind in program files: dotnet/sdk-manifests, dotnet/packs, etc.
• Install latest build: 6.0.100-preview.5.21255.7

I get a different error now:

> dotnet workload install microsoft-android-sdk-full --configfile NuGet.config

Failed to update the advertising manifest microsoft.net.workload.android: microsoft.net.workload.android.manifest-6.0.100 is not found in NuGet feeds C:\Users\jopepper\Downloads\, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json, https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json",
Failed to update the advertising manifest microsoft.net.workload.blazorwebassembly: microsoft.net.workload.blazorwebassembly.manifest-6.0.100 is not found in NuGet feeds C:\Users\jopepper\Downloads\, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json, https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json",
Failed to update the advertising manifest microsoft.net.workload.ios: microsoft.net.workload.ios.manifest-6.0.100 is not found in NuGet feeds C:\Users\jopepper\Downloads\, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json, https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json",
Failed to update the advertising manifest microsoft.net.workload.maccatalyst: microsoft.net.workload.maccatalyst.manifest-6.0.100 is not found in NuGet feeds C:\Users\jopepper\Downloads\, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json, https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json",
Failed to update the advertising manifest microsoft.net.workload.macos: microsoft.net.workload.macos.manifest-6.0.100 is not found in NuGet feeds C:\Users\jopepper\Downloads\, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json, https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json",
Failed to update the advertising manifest microsoft.net.workload.tvos: microsoft.net.workload.tvos.manifest-6.0.100 is not found in NuGet feeds C:\Users\jopepper\Downloads\, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json, https://pkgs.dev.azure.com/azure-public/vside/_packaging/xamarin-impl/nuget/v3/index.json, https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json",
Installing pack Microsoft.Android.Sdk version 11.0.200-preview.4.245...
Workload installation failed, rolling back installed packs...
Installation roll back failed: Access to the path 'C:\Program Files\dotnet\metadata\workloads\InstalledPacks\v1\Microsoft.Android.Sdk\11.0.200-preview.4.245\6.0.100' is denied.
Rolling back pack Microsoft.Android.Sdk installation...
Installation roll back failed: Access to the path 'C:\Program Files\dotnet\metadata\workloads\InstalledPacks\v1\Microsoft.Android.Sdk\11.0.200-preview.4.245\6.0.100' is denied.
Workload installation failed: One or more errors occurred. (Access to the path 'C:\Program Files\dotnet\metadata\temp\microsoft.android.sdk.windows\11.0.200-preview.4.245' is denied.)
install
  Install a workload.

Usage:
  dotnet [options] workload install [<PACKAGE_ID>...]

Arguments:
  <PACKAGE_ID>  The NuGet Package Id of the workload to install.

Options:
  --sdk-version <VERSION>                                                  The version of the SDK.
  --configfile <FILE>                                                      The NuGet configuration file to use.
  --add-source <SOURCE>                                                    Add an additional NuGet package source to use during installation.
  --skip-manifest-update                                                   Skip updating the workload manifests.
  --from-cache <from-cache>                                                Complete the operation from cache (offline).
  --include-previews                                                       Allow prerelease workload manifests.
  --disable-parallel                                                       Prevent restoring multiple projects in parallel.
  --ignore-failed-sources                                                  Treat package source failures as warnings.
  --no-cache                                                               Do not cache packages and http requests.
  --interactive                                                            Allows the command to stop and wait for user input or action (for example to complete authentication).
  -v, --verbosity <d|detailed|diag|diagnostic|m|minimal|n|normal|q|quiet>  Set the MSBuild verbosity level. Allowed values are q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic].
  -?, -h, --help                                                           Show help and usage information

I tried deleting C:\Program Files\dotnet\metadata\temp\ and metadata\workloads to see if some process was using a file or directory, but it seems Explorer can delete it. It still happened when I tried again.

[jonathanpeppers]

Ok, 6.0.100-preview.5.21255.7 works fine after I double-checked and actually used an administrator command-prompt. Whoops!

So maybe we just need to list this as a known issue for Preview 4?

[jonathanpeppers]

I think we can close this, I tested with 6.0.100-preview.4.21255.9 and didn't hit this issue.

It might have been something with me manually updating WorkloadManifest.json and WorkloadManifest.targets -- as I was trying to test the latest Xamarin builds.