JIT: Fix BBJ_COND-related assert in OptIfConversionDsc::IfConvertDump

[amanasifkhalid]

In #95773, I incorrectly assumed m_startBlock would always be a BBJ_COND in OptIfConversionDsc::IfConvertDump, but it can be converted to a BBJ_ALWAYS before being dumped, thus hitting an assert when m_startBlock->GetTrueTarget() is called. This is fixed by calling the correct target accessor method depending on the type of m_startBlock.

(Note that IfConvertDump is only called if dumps are enabled, hence why this assert wasn't initially hit in CI.)

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

In #95773, I incorrectly assumed m_startBlock would always be a BBJ_COND in OptIfConversionDsc::IfConvertDump, but it can be converted to a BBJ_ALWAYS before being dumped, thus hitting an assert when m_startBlock->GetTrueTarget() is called. This is fixed by calling the correct target accessor method depending on the type of m_startBlock.

(Note that IfConvertDump is only called if dumps are enabled, hence why this assert wasn't initially hit in CI.)

Author:	amanasifkhalid
Assignees:	amanasifkhalid
Labels:	area-CodeGen-coreclr
Milestone:	-

[amanasifkhalid]

cc @dotnet/jit-contrib. @jakobbotsch thank you for catching this, PTAL.