[release/7.0-staging] [mono] Fix GetCustomAttributes System.Reflection API with a custom attribute provider#94708
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsBackport of #94602 to release/7.0-staging /cc @ivanpovazan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
The added test has successfully passed on CI. This is safe to be merged. |
|
@ivanpovazan @lambdageek did this get Tactics approval? Today's code complete. |
|
I'm flowing staging to internal now, so the branches are closed. This will have to wait until the January release. |
|
Per tactics, this change unfortunately doesn't meet the bar in terms of customer impact. @ivanpovazan if you find this blocks customers in a significant way, please identify and reopen. |
Backport of #94602 to release/7.0-staging
/cc @ivanpovazan
Customer Impact
ASP.NET test suite uses
GetCustomAttributesAPI with a custom attribute provider: https://github.com/dotnet/aspnetcore/blob/402e7fc10aa304775f50d318c8a4dafbf46dbfe0/src/Shared/PropertyAsParameterInfo.cs#L15 which was not properly supported by Mono causing about 100 failing tests, as reported here: #94437 (comment)This PR fixes the issue.
Testing
This PR includes a unit test which verifies the fix that should pass on CI.
Risk
Low.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.