[browser][HybridGlobalization] Improve logging on FirstDayOfWeek failures#93380
Merged
ilonatommy merged 4 commits intodotnet:mainfrom Oct 16, 2023
Merged
[browser][HybridGlobalization] Improve logging on FirstDayOfWeek failures#93380ilonatommy merged 4 commits intodotnet:mainfrom
ilonatommy merged 4 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsI cannot reproduce the failure from CI. We are testing hundreds of locales in the same test and logging only: on failure. Xunit's Assert.Equal does not have a
|
We do not test Invariant and en-US in hybrid mode, so it's fine to run it there as well.
This was referenced Oct 12, 2023
Member
Author
|
It turns out the failure is not on HybridGlobalization-specific test but on the general one. However, this fix will be helpful for the future anyway. |
maraf
approved these changes
Oct 13, 2023
src/libraries/System.Globalization/tests/DateTimeFormatInfo/DateTimeFormatInfoFirstDayOfWeek.cs
Show resolved
Hide resolved
This was referenced Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cannot reproduce the failure from CI. We are testing hundreds of locales in the same test and logging only:
on failure. Xunit's Assert.Equal does not have a
messageargument overload, so it was changed toAssert.Truethat has it. Now we will get e.g.Failed for culture: pl-PL. Expected: Monday, Actual: Sunday.In order to change only hybrid-focused test cases the non-hybrid cases were moved to a separate test.