Add catch for ConnectionAborted in Http3

[liveans]

It wasn't actually a race between, closing, etc. Since we're keeping the first exception in _abortException, we're returning that and in some cases, we weren't actually wrapping ConnectionAbort with HttpProtocolException, and it was resulting in throwing a QuicException.

Fixes #92359

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I don't have a good repro but according to the stack trace, it feels like abort due to dispose and close was racing.

Fixes #92359

Author:	liveans
Assignees:	-
Labels:	area-System.Net.Http
Milestone:	-

[ManickaP]

it feels like abort due to dispose and close was racing.

Could you expand on that a bit more so I can fully understand the sequence of events that could cause this?

[liveans]

it feels like abort due to dispose and close was racing.

Could you expand on that a bit more so I can fully understand the sequence of events that could cause this?

AFAIU, when we finished the serverTask Http3Connection was disposing faster than before we sent Close, so it caused QuicConnection to dispose of, and disposing of QuicConnection was causing connection aborted by peer.

[ManickaP]

Http3Connection was disposing faster than before we sent Close

CloseAsync is awaited, so we're waiting for the SHUTDOWN_COMPLETE event for the connection

disposing of QuicConnection was causing connection aborted by peer.

Dispose won't do anything if close was already called, if not, it will do the same thing as CloseAsync called with default connection close error code. Also "connection aborted by peer" is what you will get when you call CloseAsync so that should be expected:

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs

Lines 445 to 451 in ffa4ef7

	catch (QuicException ex) when (ex.QuicError == QuicError.ConnectionAborted)
	{
	Debug.Assert(ex.ApplicationErrorCode.HasValue);
	Http3ErrorCode code = (Http3ErrorCode)ex.ApplicationErrorCode.Value;
	Abort(HttpProtocolException.CreateHttp3ConnectionException(code, SR.net_http_http3_connection_close));
	}

So I think your premise is not correct and there's more to it.

[ManickaP]

LGTM, thanks!