[mono] Clean up internal usage of RuntimeComponents to always be treated as MSBuild Item#91800
Conversation
|
Tagging subscribers to this area: @directhex Issue DetailsThis PR cleans up the internal usage of This PR:
Follow-up tasks:
|
jandupej
left a comment
There was a problem hiding this comment.
This is a welcome simplification. Thanks!
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
0ec903e to
df3e41b
Compare
steveisok
left a comment
There was a problem hiding this comment.
LGTM! Thanks for refactoring and making this more straightforward.
src/libraries/System.Diagnostics.Tracing/tests/System.Diagnostics.Tracing.Tests.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failures don't seem to be related |
This PR cleans up the internal usage of
RuntimeComponentswhere in some places it is used as a MSBuildPropertyand in others as anItem, which can lead to unexpected behaviours during app builds for bothAndroidandiOS-likeplatforms and additionally imposes unnecessary complication of treating them dually in different places.This PR:
*which previously meant to include all supported components (this was probably the reason to use aPropertyin the first place).BREAKING CHANGE- however I did not find any internal usage of said feature (I might be wrong though).UseAllRuntimeComponentsMSBuild property which when set totrueincludes all supported components by parsing theRuntimeComponentManifest.jsonfile and populatingRuntimeComponentsItem in_InitializeCommonPropertiestarget (in both:AppleBuild.targetsandAndroidBuild.targets)RuntimeComponentsto be treated as MSBuildItemdiagnostic tracingRuntimeComponentManifest.targetsfor local builds and testing to retrieve available runtime componentsFollow-up tasks:
AndroidSampleAppto useAndroidBuild.targetsdirectly instead of manually inferring build tasks and targets