Skip to content

Remove FEATURE_BASICFREEZE#91132

Closed
EgorBo wants to merge 2 commits intodotnet:mainfrom
EgorBo:remove-FEATURE_BASICFREEZE
Closed

Remove FEATURE_BASICFREEZE#91132
EgorBo wants to merge 2 commits intodotnet:mainfrom
EgorBo:remove-FEATURE_BASICFREEZE

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 25, 2023

This PR drops FEATURE_BASICFREEZE if-defs assuming this feature is always enabled. Addresses @cshung's suggestion in #90847

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 25, 2023
@ghost ghost assigned EgorBo Aug 25, 2023
@EgorBo EgorBo added area-GC-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 25, 2023
@ghost
Copy link

ghost commented Aug 25, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR drops FEATURE_BASICFREEZE if-defs assuming this feature is always enabled. Addresses @cshung's suggestion in #90847

Author: EgorBo
Assignees: EgorBo
Labels:

area-GC-coreclr
Milestone: -

@EgorBo EgorBo requested a review from cshung August 25, 2023 22:37
@EgorBo
Copy link
Member Author

EgorBo commented Aug 31, 2023

@cshung ping (not urget if you're busy, just to make sure you saw it)

@cshung
Copy link
Contributor

cshung commented Aug 31, 2023

@EgorBo, thanks for doing the PR. I loved it.

Can we please hold this for just a bit? I am wondering if the GC team might have some last-minute changes that might need to backport to 8. In that case, it would be nice to not have to deal with potential conflicts.

@EgorBo
Copy link
Member Author

EgorBo commented Aug 31, 2023

@EgorBo, thanks for doing the PR. I loved it.

Can we please hold this for just a bit? I am wondering if the GC team might have some last-minute changes that might need to backport to 8. In that case, it would be nice to not have to deal with potential conflicts.

Sure, no problem at all!

@EgorBo
Copy link
Member Author

EgorBo commented Sep 22, 2023

Closing to keep number of active PRs low.

@EgorBo EgorBo closed this Sep 22, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@cshung cshung Awaiting requested review from cshung

Assignees

@EgorBo EgorBo

Labels

area-GC-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EgorBo @cshung