Update ClaimsIdentity debug display#87159
Merged
stephentoub merged 2 commits intomainfrom Jun 8, 2023
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsBoolean values are displayed as lowercase in debug display. For example: This displays IsCancellationRequested = true
|
adamsitnik
reviewed
Jun 6, 2023
Member
adamsitnik
left a comment
There was a problem hiding this comment.
Overall LGTM as long as we solve the compilation issue ;)
src/libraries/System.Security.Claims/src/System/Security/Claims/ClaimsIdentity.cs
Outdated
Show resolved
Hide resolved
…s/ClaimsIdentity.cs Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
stephentoub
approved these changes
Jun 6, 2023
Member
Author
|
What is going on with the build? Can an expert merge this if the build errors are unrelated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean values are displayed as lowercase in debug display.
For example:
runtime/src/libraries/System.Private.CoreLib/src/System/Threading/CancellationToken.cs
Line 29 in 268962e
This displays
IsCancellationRequested = trueClaimsIdentitybuilds the debug string in a method so it doesn't automatically use lowercase bool. Update it to be consistent with other debug display bool values.