Fix handling of CreateScalarUnsafe for embedded broadcast#87134
Merged
tannergooding merged 3 commits intodotnet:mainfrom Jun 7, 2023
Merged
Fix handling of CreateScalarUnsafe for embedded broadcast#87134tannergooding merged 3 commits intodotnet:mainfrom
tannergooding merged 3 commits intodotnet:mainfrom
Conversation
…alarUnsafe is coming from memory for embedded broadcast
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #87116 The root issue was that Embedded broadcast, however, explicitly requires the operand to be coming from memory and so needs to take this into account.
|
kunalspathak
approved these changes
Jun 5, 2023
Member
|
Thanks for addressing this bug in embedded broadcast! |
Member
Author
|
Merged in dotnet/main so CI could rerun and get past the timeouts that were hitting various PRs this morning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #87116
The root issue was that
CreateScalarUnsafeis a special containable node which does not necessarily come from memory. It could also be an enregistered local that we want to consume directly as part of another scalar operation.Embedded broadcast, however, explicitly requires the operand to be coming from memory and so needs to take this into account.