Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
| internal static class DiagnosticsHelper | ||
| { | ||
| internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2) | ||
| // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency. |
There was a problem hiding this comment.
Why is the dependency problematic?
There was a problem hiding this comment.
The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244
src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs
Outdated
Show resolved
Hide resolved
...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs
Show resolved
Hide resolved
src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs
Outdated
Show resolved
Hide resolved
noahfalk
left a comment
There was a problem hiding this comment.
Mostly looked good. I think I spotted two bugs and a few other suggestions inline.
The changes here addressing the following issues:
Createmethod.Microsoft.Extensions.DiagnosticstoMicrosoft.Extensions.Diagnostics.Abstractionlibrary.