[mono][aot] Use an mrgctx for all gshared methods on iOS#86583
Merged
kotlarmilos merged 1 commit intodotnet:mainfrom May 24, 2023
Merged
[mono][aot] Use an mrgctx for all gshared methods on iOS#86583kotlarmilos merged 1 commit intodotnet:mainfrom
kotlarmilos merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger Issue DetailsThis PR enables the use of the
Considering potential speed implications of such a change, I suggest merging this PR after the Preview 5 snap. Fixes #82906
|
This was referenced May 22, 2023
vargaz
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the use of the
MonoMethodRuntimeGenericContextstructure for all gshared methods, eliminating the need for generating rgctx fetch trampolines. Preliminary size saving on HelloiOS app is approximately 160kb or -0.646% in release LLVM mode.Considering potential speed implications of such a change, I suggest merging this PR after the Preview 5 snap.
Fixes #82906