[interp] Remove char element type support from transform-simd#86534
Merged
kg merged 1 commit intodotnet:mainfrom May 20, 2023
Merged
[interp] Remove char element type support from transform-simd#86534kg merged 1 commit intodotnet:mainfrom
kg merged 1 commit intodotnet:mainfrom
Conversation
Also disable unusual types for packedsimd
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos Issue DetailsIn the comments for #86475 @tannergooding caught a mistake I introduced - we don't support vectors of char, so the interp intrinsics shouldn't handle them. This PR reverses the cases I added, and also disables some of the more exotic types for packedsimd.
|
This was referenced May 20, 2023
vargaz
approved these changes
May 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the comments for #86475 @tannergooding caught a mistake I introduced - we don't support vectors of char, so the interp intrinsics shouldn't handle them.
This PR reverses the cases I added, and also disables some of the more exotic types for packedsimd.