Add support for types with parameterized ctors to config binder gen#86365
Add support for types with parameterized ctors to config binder gen#86365layomia merged 3 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsThis PR adds initial support for config types that are bound using parameterized ctors, required properties, and/or init-only properties. Needs a follow up to
|
.../Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...libraries/Microsoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...libraries/Microsoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
tarekgh
left a comment
There was a problem hiding this comment.
Added a couple of comments please address them before merging.
8640d25 to
6cd9bf7
Compare
|
Will request review again after addressing #86365 (comment). |
b5bf629 to
3b4c0b6
Compare
|
Implementation is now in sync with reflection; including exception handling, parameter-property binding... PTAL. |
...raries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
Missed that, thanks. It passes. |
This PR adds support for config types that are bound using parameterized ctors, required properties, and/or init-only properties.