[release/6.0] Port perfmap environment variable change to 6.0#84681
Merged
davmason merged 2 commits intodotnet:release/6.0-stagingfrom Apr 25, 2023
Merged
[release/6.0] Port perfmap environment variable change to 6.0#84681davmason merged 2 commits intodotnet:release/6.0-stagingfrom
davmason merged 2 commits intodotnet:release/6.0-stagingfrom
Conversation
jeffschwMSFT
approved these changes
Apr 12, 2023
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 6.0.x. please get a code review
noahfalk
approved these changes
Apr 14, 2023
Contributor
|
@davmason thanks for re-targeting to 6.0-staging. PR submitters now have permission to merge their own PRs once all the requirements are met:
Hit the squash&merge button whenever! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #82142 to 6.0
Customer Impact
An internal partner team is running in to performance issues with generating both jit dumps and perfmap files. Currently we unconditionally do both and it all of the file IO can cause noticeable regressions. This change makes it so you can specify whether you want perfmaps, jit dumps, or both written out.
Testing
Partner team validation that it fixes their scenario.
Risk
Low, no known issues