[release/6.0] Microsoft.NETCore.Platforms: support adding rids with '-' in the base part (backport #84413)#84442
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #84413 Per @tmds Customer impact#77508 was merged, but its installer counterpart (dotnet/installer#14816) was NAKed due to safety concerns. This revealed a limit with Microsoft.NETCore.Platforms parsing of RID. Thus, build of source-build on linux-musl platforms is currently broken. A few approches on installer side can be implemented as workarounds, but ideally the fix should be on runtime side. This also unblocks dotnet/installer#13074. Testing
RiskLow, there were limited changes in that code between
|
d2c6e3b to
94dc504
Compare
021a7a6 to
6c12423
Compare
For some more context: This change set had two goals: eliminate portable build of runtime (in installer), and update the runtime graph with the target rid (in runtime). Because only the runtime part got merged, we're now in a situation where the portable build ensures the target rid (which is the portable rid) is in the graph. I think @ayakael has been patching his builds to work around this issue. And the issue has now surfaced again with @omajid working on adding a source-build 6.0 CI leg for Alpine: dotnet/installer#13074. |
6c12423 to
d6d9fe8
Compare
|
Today is code complete for the May Release. If we want this fix to get included in that release, please get the PR ready to merge before 4pm PT today:
Otherwise, this will have to go into the June Release. |
|
I'm treating this as tell-mode since the affected cs file is a build task, so not customer facing. I notified Tactics anyway just so they were informed. |
Backport of #84413
Per @tmds
Customer impact
#77508 was merged, but its installer counterpart (dotnet/installer#14816) was NAKed due to safety concerns. This revealed a limit with Microsoft.NETCore.Platforms parsing of RID. Thus, build of source-build on linux-musl platforms is currently broken. A few approches on installer side can be implemented as workarounds, but ideally the fix should be on runtime side.
This also unblocks dotnet/installer#13074.
Testing
Risk
Low, there were limited changes in that code between
release/6.0andmain./cc: @ericst @tmds @omajid