Use underlying type converter for nullable type#84208
Merged
eiriktsarpalis merged 8 commits intodotnet:mainfrom May 31, 2023
Merged
Use underlying type converter for nullable type#84208eiriktsarpalis merged 8 commits intodotnet:mainfrom
eiriktsarpalis merged 8 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFixes #66547
|
Contributor
Author
|
Hi @krwq I'm closing this PR since @eiriktsarpalis already fixed it as part of #84015 see : |
Member
|
@pedrobsaila would it be possible to rebase your PR so that the tests that you added can be included? Thanks |
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
…neration.Unit.Tests/JsonSourceGeneratorTests.cs
…neration.Unit.Tests/JsonSourceGeneratorTests.cs
eiriktsarpalis
approved these changes
May 31, 2023
Member
eiriktsarpalis
left a comment
There was a problem hiding this comment.
I've pushed further commits adding runtime tests and making necessary changes to the emitter.
This was referenced May 31, 2023
This was referenced Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66547