Fix src/tests/build.sh argument processing#81836
Conversation
|
Tagging subscribers to this area: @hoyosjs Issue DetailsIn #81439 I added logic to src/tests/build.sh that would support the same syntax as the cmd script for the test filter args. However, this isn't working correctly because the Without this fix,
|
trylek
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Sven! Please note however that @jeffhandley is right now reviewing
including a broad revamp of the script so please consider syncing up with him to incorporate your change in his, otherwise you'll end up with a huge conflict and will need to basically redo your change.
|
Failure is #81859 |
In #81439 I added logic to src/tests/build.sh that would support the same syntax as the cmd script for the test filter args. However, this isn't working correctly because the
shifthappens inside a sourced script, and doesn't actually shift the outer arguments. The right way to do this is via__ShiftArgs.Without this fix,
tree nativeaotwas working becausenativeaothappened to be a supported argument as well. With the fix, other test subtrees work as expected.