Skip to content

Fix nullability on IDesignerSerializationProvider.GetSerializer#81203

Merged
stephentoub merged 2 commits intodotnet:mainfrom
elachlan:IDesignerSerializationProvider-nullability
Jan 31, 2023
Merged

Fix nullability on IDesignerSerializationProvider.GetSerializer#81203
stephentoub merged 2 commits intodotnet:mainfrom
elachlan:IDesignerSerializationProvider-nullability

Conversation

@elachlan
Copy link
Contributor

Related to ongoing work to null annotate the winforms codebase.

The annotations for IDesignerSerializationProvider.GetSerializer() need to be updated to reflect nullability for params currentSerializer and objectType as these parameters should allow null.

dotnet/winforms#8353 (comment)

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.ComponentModel labels Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to ongoing work to null annotate the winforms codebase.

The annotations for IDesignerSerializationProvider.GetSerializer() need to be updated to reflect nullability for params currentSerializer and objectType as these parameters should allow null.

dotnet/winforms#8353 (comment)

Author: elachlan
Assignees: -
Labels:

area-System.ComponentModel, community-contribution

Milestone: -

@elachlan
Copy link
Contributor Author

CC: @lonitra @KlausLoeffelmann

@elachlan elachlan requested a review from stephentoub January 30, 2023 05:25
@stephentoub stephentoub merged commit 37b12da into dotnet:main Jan 31, 2023
@elachlan elachlan deleted the IDesignerSerializationProvider-nullability branch January 31, 2023 20:00
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.ComponentModel community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants