Revert Async changes in SNIPacket to fix deadlock issues#778
Merged
Conversation
Member
Author
|
@danmosemsft We want to push this fix to System.Data.SqlClient for versions 4.7.0+ (.NET Core 3.0+). |
David-Engel
approved these changes
Dec 11, 2019
Member
|
cc: @benaadams |
Member
|
Is a bit weird; but I can't recreate the issue (to ensure its resolved) and my PR attempts thus far haven't succeeded in fixing it when others try them. So reverting which seems to fix it is probably the best approach right now. |
karinazhou
approved these changes
Dec 13, 2019
stephentoub
approved these changes
Dec 13, 2019
stephentoub
left a comment
Member
There was a problem hiding this comment.
Assuming this is a pure revert / the code is exactly what it was before, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/SqlClient#262 by reverting dotnet/corefx#34184.