Reinstate strict prototypes warning#76463
Merged
jkotas merged 14 commits intodotnet:mainfrom Oct 1, 2022
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
5879c4a to
ddf7b91
Compare
ddf7b91 to
5c1a7f7
Compare
Contributor
Author
|
Thanks @jkotas . Are you expecting it to go through, or do you want me to pick up more of the voids today? |
Member
|
I can take care of it. I hope that the current CI run will be green. There is a ton of these warnings in zlib that we want to wait for being fixed in the upstream zlib sources first. So I had to add some of the warning disable command line options back. |
jkotas
approved these changes
Oct 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reinstates the
strict-prototypewarning in most places. I wasn't able to do the one inSystem.IO.Compressionruntime/src/native/libs/System.IO.Compression.Native/CMakeLists.txt
Line 42 in 5481c4b
because of these
Which look like a slightly different problem to the one of a missing
voidin the.c.function signature. Do you want me to investigate theadler32.cones more?This originates from the PR over at dotnet/runtimelab#2004 (comment)
Tested by running