Skip to content

JIT: assign plausible loop number to new throw helper blocks#74978

Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS:Fix74739
Sep 2, 2022
Merged

JIT: assign plausible loop number to new throw helper blocks#74978
AndyAyersMS merged 1 commit intodotnet:mainfrom
AndyAyersMS:Fix74739

Conversation

@AndyAyersMS
Copy link
Member

These can get added during CSE and may appear in a span of blocks that
comprise an existing loop.

Annotate the new blocks as belonging to an appropriate loop, even though
by rights they don't belong to any loop.

Closes #74739.

These can get added during CSE and may appear in a span of blocks that
comprise an existing loop.

Annotate the new blocks as belonging to an appropriate loop, even though
by rights they don't belong to any loop.

Closes dotnet#74739.
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 2, 2022
@ghost ghost assigned AndyAyersMS Sep 2, 2022
@AndyAyersMS
Copy link
Member Author

@jakobbotsch PTAL
cc @dotnet/jit-contrib

@ghost
Copy link

ghost commented Sep 2, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

These can get added during CSE and may appear in a span of blocks that
comprise an existing loop.

Annotate the new blocks as belonging to an appropriate loop, even though
by rights they don't belong to any loop.

Closes #74739.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS AndyAyersMS merged commit 635ecd6 into dotnet:main Sep 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failed 'block->bbNatLoopNum == loopNum' during 'Optimize Valnum CSEs'

2 participants