Reuse more Microsoft.Interop.SourceGeneration code in JS generators#74949
Merged
jkoritzinsky merged 4 commits intodotnet:mainfrom Sep 9, 2022
Merged
Reuse more Microsoft.Interop.SourceGeneration code in JS generators#74949jkoritzinsky merged 4 commits intodotnet:mainfrom
jkoritzinsky merged 4 commits intodotnet:mainfrom
Conversation
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
the wasm built test failures are likely from #74897 @ericstj @danmoseley can you verify? |
Member
|
Yes: That's been fixed now, we can retrigger the pipeline. |
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…SourceGeneration.GeneratedStatements and ContainingSyntaxContext types.
…cating the logic.
99a95ea to
5c8eaa3
Compare
pavelsavara
reviewed
Sep 8, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
pavelsavara
reviewed
Sep 8, 2022
| AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(GeneratorVersion))) | ||
| })))))); | ||
| } | ||
| string stubTypeFullName = method.ContainingType.ToDisplayString(new SymbolDisplayFormat(typeQualificationStyle: SymbolDisplayTypeQualificationStyle.NameAndContainingTypesAndNamespaces)); |
Member
There was a problem hiding this comment.
NameAndContainingTypesAndNamespaces is better than what we have in the GetFullyQualifiedMethodName and s_typeNameFormat, please unify it.
Member
There was a problem hiding this comment.
If we use NameAndContainingTypesAndNamespaces in GetFullyQualifiedMethodName, how do we determine which "." separate class names and which namespace names?
Context: mono special naming convention requires to separate class names with / and namespaces with '.'.
Member
Author
There was a problem hiding this comment.
I think to meet the Mono naming requirements with NameAndContainingTypesAndNamespaces would require us to go back to using ToDisplayParts(). I'll leave that for now since we just moved away from that.
pavelsavara
reviewed
Sep 8, 2022
...ies/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSExportCodeGenerator.cs
Show resolved
Hide resolved
pavelsavara
reviewed
Sep 8, 2022
...es/System.Runtime.InteropServices/gen/LibraryImportGenerator/DefaultMarshallingInfoParser.cs
Outdated
Show resolved
Hide resolved
pavelsavara
reviewed
Sep 8, 2022
...aries/System.Runtime.InteropServices.JavaScript/gen/JSImportGenerator/JSImportStubContext.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse more of the code in Microsoft.Interop.SourceGeneration in the JavaScript source generators instead of duplicating the logic.
Refactor the JavaScript generators to use the GeneratedStatements type instead of providing its own JSGeneratedStatements type.
Refactor the JSSignatureContext type to wrap a SignatureContext instead of providing a very similar surface area with a lot of duplicated code.
This PR also enhances the API surface of types in Microsoft.Interop.SourceGeneration to enable these sorts of scenarios.