Reenable test Runtime_34170 outside of Arm32 runs#74185
Reenable test Runtime_34170 outside of Arm32 runs#74185ivdiazsa merged 2 commits intodotnet:mainfrom ivdiazsa:reenable_34170_noarm32
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/tests/issues.targets
Outdated
| <ExcludeList Include="$(XunitTestBinBase)/JIT/jit64/regress/vsw/373472/**"> | ||
| <Issue>Allocates large contiguous array that is not consistently available on 32-bit platforms</Issue> | ||
| </ExcludeList> | ||
| <ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/JitBlue/Runtime_34170/Runtime_34170/*"> |
There was a problem hiding this comment.
hmm.. this might disable it for non-crossgen2 cases as well. Might make sense to discuss with @trylek if there is a way to disable for crossgen2+arm32 only?
There was a problem hiding this comment.
At this point we don't have a pre-existing section in issues.targets specifically targeting Crossgen2+arm32 but it's trivial to add that e.g. after the general Crossgen2 section by just copying the conditional ItemGroup and modifying the conditional check to include '$(TargetArchitecture)' == 'arm' or '$(AltJitArch)' == 'arm'.
There was a problem hiding this comment.
That sounds good. I'm going to add that subset to the Crossgen2 section of disabled tests.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsTest failure described in detail in #53560. After multiple attempts, could not get this test failure to repro on any other architecture. Since we don't have anything that suggests it's blocking customers, moved it to the Arm32 exclusive disabled tests, and changed the milestone to .NET 8.0.
|
Test failure described in detail in #53560. After multiple attempts, could not get this test failure to repro on any other architecture. Since we don't have anything that suggests it's blocking customers, moved it to the Arm32 exclusive disabled tests, and changed the milestone to .NET 8.0.