Ensure methods on different instantiations are reflectable#73749
Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom Aug 11, 2022
Merged
Ensure methods on different instantiations are reflectable#73749MichalStrehovsky merged 2 commits intodotnet:mainfrom
MichalStrehovsky merged 2 commits intodotnet:mainfrom
Conversation
jkotas
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something I noticed among the failures in #73547.
See the regression test - since it doesn't trigger AOT or trimming warnings, it needs to "just work". What we need to do to fix this is to force generation of code on things that have a type handle (i.e. the type is reflection-visible) and reflection visible method definitions. We would previously fail at the
Invokestep since no method body was generated for this instantiation.This is a size regression - it's 4 kB on a hello world - but we need it for correctness.
Cc @dotnet/ilc-contrib