Skip assertion list look ups where unnecessary#73142
Merged
kunalspathak merged 7 commits intodotnet:mainfrom Aug 18, 2022
Merged
Skip assertion list look ups where unnecessary#73142kunalspathak merged 7 commits intodotnet:mainfrom
kunalspathak merged 7 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@dotnet/jit-contrib |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBelow is the list of metrics that I gathered before and after this change. They are based upon the instrumentation I added in #73035.
Benchmarks
Libraries
Asp
|
Contributor
Author
|
Ping. now that main is open for 8.0 |
BruceForstall
approved these changes
Aug 17, 2022
Contributor
BruceForstall
left a comment
There was a problem hiding this comment.
LGTM.
I think you should wait until we have a new SPMI collection and then rebase/re-trigger PR testing to ensure no diffs and that testing is recent.
a707dda to
9b44443
Compare
Contributor
Author
|
No diffs as expected and the replay/diff failures are fixed in #74095 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below is the list of metrics that I gathered before and after this change. They are based upon the instrumentation I added in #73035.
*CallCount: Number of times we go through the look-up of that assertion category.*MissedCount: Number of times we don't find any match of that assertion category.*MissedIter: Number of iterations we spend before we realize there is no match.Benchmarks
Libraries
Asp