Make revocation tests use CRLBuilder instead of its own copy#72886
Merged
bartonjs merged 1 commit intodotnet:mainfrom Jul 27, 2022
Merged
Make revocation tests use CRLBuilder instead of its own copy#72886bartonjs merged 1 commit intodotnet:mainfrom
bartonjs merged 1 commit intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsSome test cleanup that got missed in the CRLBuilder PR
|
vcsjones
reviewed
Jul 27, 2022
...ystem.Security.Cryptography.X509Certificates/tests/RevocationTests/DynamicRevocationTests.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
I learned not to ctrl+click multiple commits and then choose revert. That only chooses the last one you selected and if it's not the top you get to merge conflict with yourself. So I just squashed everything down to the one commit and force pushed. Dear GitHub, I don't know what you're doing when you update the merge status grid/block/whatever, but quit moving my focus to a different textbox. |
Member
vcsjones
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some test cleanup that got missed in the CRLBuilder PR