Skip to content

Update the CustomMarshallerAttributeFixer to support adding missing methods for stateless marshaller shapes #72869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 5 commits into from
Jul 28, 2022
Merged

Update the CustomMarshallerAttributeFixer to support adding missing methods for stateless marshaller shapes #72869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a520055
Enable the fixer to add the ConvertToManaged/ConvertToUnmanaged metho…
jkoritzinsky Jul 22, 2022
d878a11
Add support for adding BufferSize
jkoritzinsky Jul 22, 2022
93c836e
Add tests for LinearCollection missing method fixes
jkoritzinsky Jul 26, 2022
31356cc
PR feedback
jkoritzinsky Jul 26, 2022
43860ea
PR feedback.
jkoritzinsky Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,7 @@ internal static DiagnosticDescriptor GetDefaultMarshalModeDiagnostic(DiagnosticD
public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
ImmutableArray.Create(
MarshallerTypeMustSpecifyManagedTypeRule,
MarshallerTypeMustBeStaticClassOrStructRule,
UnmanagedTypeMustBeUnmanagedRule,
GetPinnableReferenceReturnTypeBlittableRule,
TypeMustHaveExplicitCastFromVoidPointerRule,
Expand Down Expand Up @@ -653,7 +654,7 @@ void ReportDiagnosticsForMissingMembers(DiagnosticReporter diagnosticReporter)
if (isLinearCollectionMarshaller)
{
// Verify that all of the following methods are present with valid shapes:
// - AllocateContainerForUnmanagedElements
// - AllocateContainerForManagedElements
// - GetUnmanagedValuesSource
// - GetManagedValuesDestination
if (methods.ToManaged is null && methods.ToManagedFinally is null)
Expand All @@ -662,7 +663,7 @@ void ReportDiagnosticsForMissingMembers(DiagnosticReporter diagnosticReporter)
StatelessLinearCollectionRequiresTwoParameterAllocateContainerForManagedElementsRule,
MissingMemberNames.CreateDiagnosticPropertiesForMissingMembersDiagnostic(
mode,
ShapeMemberNames.LinearCollection.Stateless.AllocateContainerForUnmanagedElements),
ShapeMemberNames.LinearCollection.Stateless.AllocateContainerForManagedElements),
marshallerType.ToDisplayString(),
mode,
managedType.ToDisplayString());
Expand Down
Loading