Skip to content

Do not spill "mis-sized" struct args passed on stack#71399

Merged
BruceForstall merged 6 commits intodotnet:mainfrom
SingleAccretion:No-Stk-Arg-Spilling-Upstream
Jul 5, 2022
Merged

Do not spill "mis-sized" struct args passed on stack#71399
BruceForstall merged 6 commits intodotnet:mainfrom
SingleAccretion:No-Stk-Arg-Spilling-Upstream

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jun 28, 2022 •
edited
Loading

It is not necessary; all backends as of this change (which includes support for LA, ported line-by-line from my corresponding ARM/ARM64 changes) support them directly.

A bit surprisingly, we have little coverage of such structs, so I added some (covering ARM/ARM64 and LA).

Just two diffs on Unix x64.

@ghost ghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Jun 28, 2022
@ghost
Copy link

ghost commented Jun 28, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

It is not necessary; all backends as of this change (which includes support for LA, ported line-by-line from my corresponding ARM/ARM64 changes) support them directly.

A bit surprisingly, we have little coverage of such structs, so I also added some (covering ARM/ARM64 and LA).

Few diffs if any are expected.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@SingleAccretion SingleAccretion force-pushed the No-Stk-Arg-Spilling-Upstream branch 2 times, most recently from 81a76bc to 733aa6e Compare June 28, 2022 20:22
@SingleAccretion SingleAccretion marked this pull request as ready for review June 29, 2022 09:05
@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Jun 29, 2022

@dotnet/jit-contrib, @shushanhf

@JulieLeeMSFT JulieLeeMSFT added this to the 7.0.0 milestone Jul 1, 2022
@JulieLeeMSFT
Copy link
Member

JulieLeeMSFT commented Jul 1, 2022

@BruceForstall, PTAL LoongArch64 change.

@shushanhf
Copy link
Contributor

shushanhf commented Jul 1, 2022

@BruceForstall, PTAL LoongArch64 change.

@SingleAccretion
Thanks very much for your contributing about LoongArch64！！！
Could you email to me ? I will send a free clound account of the LoongArch64 that can be used for testing the LoongArch64.
Recently I will also test the LoongArch64.

@SingleAccretion SingleAccretion force-pushed the No-Stk-Arg-Spilling-Upstream branch from 733aa6e to bd1ead0 Compare July 2, 2022 14:33
@SingleAccretion SingleAccretion mentioned this pull request Jul 3, 2022
Merged
@BruceForstall BruceForstall merged commit eb123a7 into dotnet:main Jul 5, 2022
@SingleAccretion SingleAccretion deleted the No-Stk-Arg-Spilling-Upstream branch July 7, 2022 20:10
@ghost ghost locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@BruceForstall BruceForstall BruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BruceForstall BruceForstall

@SingleAccretion SingleAccretion

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion @JulieLeeMSFT @shushanhf @BruceForstall