Simplify AssemblyName marshalling between VM and CoreLib#68735
Merged
jkotas merged 1 commit intodotnet:mainfrom May 1, 2022
Merged
Simplify AssemblyName marshalling between VM and CoreLib#68735jkotas merged 1 commit intodotnet:mainfrom
jkotas merged 1 commit intodotnet:mainfrom
Conversation
Member
jkotas
commented
Apr 30, 2022
- Introduce NativeAssemblyNameParts that is unmanaged view for the managed AssemblyNameParts
- Use NativeAssemblyNameParts to convert manually managed code to C#
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Details
|
123df0c to
90c3209
Compare
jkotas
commented
Apr 30, 2022
jkotas
commented
Apr 30, 2022
src/libraries/System.Private.CoreLib/src/System/Reflection/AssemblyName.cs
Outdated
Show resolved
Hide resolved
jkotas
commented
Apr 30, 2022
Member
Author
There was a problem hiding this comment.
This is mirroring the logic that used to be in C++
stephentoub
reviewed
Apr 30, 2022
src/coreclr/System.Private.CoreLib/src/System/Reflection/AssemblyName.CoreCLR.cs
Outdated
Show resolved
Hide resolved
b2e096c to
0793a7e
Compare
Member
Author
|
This is contributing towards moving more of assembly loader to C#. The next step after this PR is going to switch assembly name parsing to be C# only and delete the C++ parser. |
jkotas
commented
Apr 30, 2022
src/coreclr/System.Private.CoreLib/src/System/Reflection/AssemblyName.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
commented
Apr 30, 2022
VSadov
reviewed
Apr 30, 2022
src/coreclr/System.Private.CoreLib/src/System/Reflection/AssemblyName.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
commented
Apr 30, 2022
src/coreclr/System.Private.CoreLib/src/System/Reflection/AssemblyName.CoreCLR.cs
Outdated
Show resolved
Hide resolved
VSadov
reviewed
Apr 30, 2022
9b1d81c to
b8ccd39
Compare
- Introduce NativeAssemblyNameParts that is unmanaged view for the managed AssemblyNameParts - Use NativeAssemblyNameParts to convert manually managed code to C# - Delete unnecessary Version allocation
b8ccd39 to
a18c80e
Compare
Member
Author
|
This is ready for review. |
|
Please stop emailing me.
…Sent from my iPhone
On Apr 30, 2022, at 10:36 AM, Jan Kotas ***@***.***> wrote:
@jkotas commented on this pull request.
In src/libraries/System.Private.CoreLib/src/System/Reflection/AssemblyName.cs:
> @@ -46,7 +46,7 @@ public AssemblyName(string assemblyName)
}
if (parts._cultureName != null)
- _cultureInfo = new CultureInfo(parts._cultureName);
+ _cultureInfo = CultureInfo.GetCultureInfo(parts._cultureName);
CultureInfo.GetCultureInfo caches the CultureInfo instances. Avoids allocation and initialization costs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
Member
|
Improvement: dotnet/perf-autofiling-issues#5076 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.