[release/6.0-rc1] [HTTP/3] Abort response stream on dispose if content not finished#57999
Merged
danmoseley merged 3 commits intorelease/6.0-rc1from Aug 24, 2021
Merged
Conversation
…ntents are finsihed
…ding state within Send* methods.
|
Tagging subscribers to this area: @dotnet/ncl |
karelz
approved these changes
Aug 24, 2021
Member
|
Approved for 6.0 RC1 by Tactics via email on 8/23. |
Member
|
Unrelated infra-network problems in wasm, re-running just in case. |
This was referenced Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57156 to release/6.0-rc1
Sends abort read/write if H/3 stream is disposed before respective contents are finished.
Fixes #56129
/cc @karelz @ManickaP
Customer Impact
Causes data loss / data corruption on server side.
Blocking ASP.NET (cc @adityamandaleeka)
Testing
CI (tests are part of the PR)
Local stress validation: 10,000 tight loop runs (without the fix it failed in ~500 iterations)
Risk
Low, H/3 only code path (hidden behind AppContext switch).
Impact on H/3 is Low/Medium -- the change is scoped only to error code path.