Handle ambient activities in EventSource test#56442
Merged
josalem merged 2 commits intodotnet:mainfrom Jul 30, 2021
Merged
Conversation
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue Detailsresolves #56279
|
noahfalk
reviewed
Jul 28, 2021
src/libraries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsUserErrors.cs
Outdated
Show resolved
Hide resolved
noahfalk
approved these changes
Jul 28, 2021
Member
noahfalk
left a comment
There was a problem hiding this comment.
LGTM, though I am a little surprised we'd need to suppress the RelatedActivityId check
stephentoub
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #56279