Skip to content

[Mono][Test] Make Interpreter Lane Run Interpreter#54201

Closed
naricc wants to merge 6 commits intodotnet:mainfrom
naricc:naricc/runtime-interpreter-test
Closed

[Mono][Test] Make Interpreter Lane Run Interpreter#54201
naricc wants to merge 6 commits intodotnet:mainfrom
naricc:naricc/runtime-interpreter-test

Conversation

@naricc
Copy link
Contributor

@naricc naricc commented Jun 15, 2021 •
edited
Loading

Add a test to verify mono interpreter lanes are running the interpreter.

@naricc naricc added test-bug Problem in test source code (most likely) area-Infrastructure-mono labels Jun 15, 2021
@ghost
Copy link

ghost commented Jun 15, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes an error where the mono interpreter test lane is not actually running the interpreter. It also adds a test so that can not easily be broken in the future.

This is a draft while I make sure everything is working in CI.

Author: naricc
Assignees: -
Labels:

area-Infrastructure-mono, test bug
Milestone: -

@naricc
Copy link
Contributor Author

naricc commented Jun 15, 2021

@imhameed This is the test I mentioned last Friday, to verify we are running the interpreter.

@fanyang-mono
Copy link
Member

fanyang-mono commented Jun 21, 2021

FYI, my RP which includes the interpreter fix has been merged #54084 Please continue with this PR to check in the test.

@naricc naricc force-pushed the naricc/runtime-interpreter-test branch 2 times, most recently from ca3fe52 to 0786f17 Compare June 25, 2021 00:15
@naricc naricc force-pushed the naricc/runtime-interpreter-test branch from 57924e2 to 4a59ba1 Compare June 28, 2021 14:36
@naricc naricc marked this pull request as ready for review June 28, 2021 14:48
@naricc naricc requested review from fanyang-mono and imhameed June 28, 2021 14:48
@naricc naricc changed the title [DRAFT][Mono][Test] Make Interpreter Lane Run Interpreter [Mono][Test] Make Interpreter Lane Run Interpreter Jun 28, 2021
fanyang-mono
fanyang-mono reviewed Jun 28, 2021
View reviewed changes
@steveisok
Copy link
Member

steveisok commented Aug 31, 2021

@naricc Are you still working on this?

@naricc
Copy link
Contributor Author

naricc commented Aug 31, 2021

@steveisok For some reason the filter in issues.targets wasn't working correctly, and I got distracted from looking into why. I will finish it up or close it.

@naricc
Copy link
Contributor Author

naricc commented Sep 1, 2021

I haven't had a chance to look at this before vacation, so I am closing it for now, but I think it is worth reopening in the future.

@naricc naricc closed this Sep 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanyang-mono fanyang-mono fanyang-mono left review comments

@imhameed imhameed Awaiting requested review from imhameed

Assignees

No one assigned

Labels

area-Infrastructure-mono test-bug Problem in test source code (most likely)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naricc @fanyang-mono @steveisok