Switch over the runtime outerloop pipeline to use Crossgen2#51444
Closed
trylek wants to merge 1 commit intodotnet:mainfrom
Closed
Switch over the runtime outerloop pipeline to use Crossgen2#51444trylek wants to merge 1 commit intodotnet:mainfrom
trylek wants to merge 1 commit intodotnet:mainfrom
Conversation
With this change, the only remaining pipelines using Crossgen1 are "r2r.yml", "r2r-extra.yml" and "release-tests.yml". I haven't yet identified the pipeline running the "release-tests.yml" script; for the "r2r*.yml", these now remain the only pipelines exercising Crossgen1. I don't think it makes sense to switch them over to CG2 as we already have their CG2 counterparts; my expectation is that, once CG1 is finally decommissioned, they will be just deleted. Thanks Tomas
Member
Author
|
Thanks Manish for the review. One more hurdle here is that this change is actually blocked on as otherwise several outerloop tests fail on x86 and arm - we have always run the Crossgen2 outerloop tests on x64 / arm64 only, for 32-bit platforms we have just the "comparison runs" which apparently don't cover all the corner cases. I don't think it's super important to beef up the existing Crossgen2 testing as this PR is going to fill that coverage gap, it's just that we need to maintain the proper sequencing to keep CI healthy. |
Member
Author
|
I have combined the change with the PR #51416 fixing the regression test 46239 and a few other issues as otherwise merging this in would break the outerloop runs with these errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the only remaining pipelines using Crossgen1 are
"r2r.yml", "r2r-extra.yml" and "release-tests.yml". I haven't yet
identified the pipeline running the "release-tests.yml" script;
for the "r2r*.yml", these now remain the only pipelines exercising
Crossgen1. I don't think it makes sense to switch them over to
CG2 as we already have their CG2 counterparts; my expectation is
that, once CG1 is finally decommissioned, they will be just deleted.
Thanks
Tomas
/cc @dotnet/crossgen-contrib @dotnet/runtime-infrastructure