Fix remaining ILLink warnings in System.Reflection#45984
Merged
eerhardt merged 7 commits intodotnet:masterfrom Dec 16, 2020
Merged
Fix remaining ILLink warnings in System.Reflection#45984eerhardt merged 7 commits intodotnet:masterfrom
eerhardt merged 7 commits intodotnet:masterfrom
Conversation
marek-safar
reviewed
Dec 12, 2020
src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/ConstructorBuilder.cs
Outdated
Show resolved
Hide resolved
vitek-karas
reviewed
Dec 14, 2020
src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/MulticastDelegate.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeAssembly.cs
Outdated
Show resolved
Hide resolved
src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeModule.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
I believe I have addressed all feedback. Please take another look. |
vitek-karas
approved these changes
Dec 14, 2020
…ddress ILLink warnings.
Annotate Delegate.BindToMethod with DynamicallyAccessedMembers Fix up requires unreferenced code comments
e7a0cc3 to
529996a
Compare
eerhardt
commented
Dec 15, 2020
| CannotRemoveAttribute : Attribute 'System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute' exists on 'System.Delegate.CreateDelegate(System.Type, System.Type, System.String, System.Boolean)' in the contract but not the implementation. | ||
| CannotRemoveAttribute : Attribute 'System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute' exists on 'System.Delegate.CreateDelegate(System.Type, System.Type, System.String, System.Boolean, System.Boolean)' in the contract but not the implementation. | ||
| Compat issues with assembly netstandard: | ||
| CannotRemoveAttribute : Attribute 'System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute' exists on 'System.Delegate.CreateDelegate(System.Type, System.Type, System.String)' in the contract but not the implementation. |
Member
Author
There was a problem hiding this comment.
Member
Author
|
The CI is green. I’ll merge this later today unless I hear anymore feedback. |
akoeplinger
added a commit
to dotnet/sdk
that referenced
this pull request
Dec 17, 2020
dotnet-maestro bot
added a commit
to dotnet/sdk
that referenced
this pull request
Dec 17, 2020
[master] Update dependencies from dotnet/runtime - Remove unnecessary reference to System.Text.Json - Update linker baseline - Update runtime dependency - Adjust ILLink warning baseline dotnet/runtime#44409 caused ILLink warning changes that are reflected in the output of linking 'hello, world'. - Merge remote-tracking branch 'upstream/master' into darc-master-4a612234-0bdd-45db-8d7f-6c5bed075213 - Fix ILLink_verify_analysis_warnings_hello_world_app - Remove ILLink warnings that were fixed by dotnet/runtime#45984
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the remaining ILLink warnings from System.Private.CoreLib that are not in one of the following areas:
Contributes to #45623