[release/5.0] Fix GC hole with STOREIND of LCL_VAR_ADDR/LCL_FLD_ADDR#45947
Merged
mmitche merged 1 commit intodotnet:release/5.0from Dec 11, 2020
Merged
[release/5.0] Fix GC hole with STOREIND of LCL_VAR_ADDR/LCL_FLD_ADDR#45947mmitche merged 1 commit intodotnet:release/5.0from
mmitche merged 1 commit intodotnet:release/5.0from
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of (part of) #45818 to release/5.0
Fixes: #45557
Customer Impact
Reported by Roslyn. Bad GC info can lead to an unexplained crash that can't easily be found or worked around.
Regression?
Yes, this is a regression from .NET Core 3.1
Testing
Manual, new unit test, CLR outerloop, SuperPMI asm diffs.
Risk
Low