Make PortableThreadPool to check events correctly before firing them#45666
Merged
sywhang merged 1 commit intodotnet:masterfrom Dec 7, 2020
Merged
Make PortableThreadPool to check events correctly before firing them#45666sywhang merged 1 commit intodotnet:masterfrom
sywhang merged 1 commit intodotnet:masterfrom
Conversation
|
Hello @sywhang! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
Author
|
Test failure is a known issue: #45654 |
Contributor
|
Thanks for finding this, I have a follow-up PR in #45681, please take a look |
kouvel
added a commit
that referenced
this pull request
Dec 7, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PortableThreadPool is firing several verbose events without checking whether they are enabled properly. Specifically they need to be checked with the proper
EventLevelandEventKeywordsbut they were only being checked via the defaultIsEnabled()method which will return true whenever any event under NativeRuntimeEventSource is enabled.This should also fix #45660.