Skip to content

Build armv7+armv7s for ios.#43350

Merged
vargaz merged 1 commit intodotnet:masterfrom
vargaz:cmake-default4
Oct 13, 2020
Merged

Build armv7+armv7s for ios.#43350
vargaz merged 1 commit intodotnet:masterfrom
vargaz:cmake-default4

Conversation

@vargaz
Copy link
Contributor

@vargaz vargaz commented Oct 13, 2020

No description provided.

@vargaz vargaz requested a review from marek-safar as a code owner October 13, 2020 10:32
@vargaz vargaz requested a review from akoeplinger October 13, 2020 10:32
@vargaz
Copy link
Contributor Author

vargaz commented Oct 13, 2020

This might not be work, testing it at
#42119

@vargaz
Copy link
Contributor Author

vargaz commented Oct 13, 2020

Removed the sysroot stuff it seems to break the build.

@vargaz vargaz changed the title Build armv7+armv7s for ios. Don't set CMAKE_OSX_SYSROOT, its not needed. Build armv7+armv7s for ios. Oct 13, 2020
@vargaz vargaz merged commit 477363b into dotnet:master Oct 13, 2020
@vargaz vargaz deleted the cmake-default4 branch October 13, 2020 13:35
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@stephentoub stephentoub stephentoub approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

No one assigned

Labels

area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vargaz @akoeplinger @stephentoub