Re-add linker attributes to generic type params of JsonSerializer methods#42186
Merged
layomia merged 1 commit intodotnet:masterfrom Sep 14, 2020
Merged
Re-add linker attributes to generic type params of JsonSerializer methods#42186layomia merged 1 commit intodotnet:masterfrom
layomia merged 1 commit intodotnet:masterfrom
Conversation
jkotas
approved these changes
Sep 14, 2020
Member
How was this missed? Is there a bug in the ref-file auto-generation in handling these? |
Contributor
Author
Yes, attributes on generic type params are currently being ignored. Called out in #41957 (comment). cc @safern on whether this is known/tracked. |
Contributor
Author
|
/backport to release/5.0-rc2 |
Contributor
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/253206255 |
Member
|
Yeah, that's a known issue: dotnet/arcade#5925 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed in #41484.