[WIP] Synchronize the update to heap_segment_committed and heap_segment_used with allocation#41950
Closed
cshung wants to merge 1 commit intodotnet:mainfrom
Closed
[WIP] Synchronize the update to heap_segment_committed and heap_segment_used with allocation#41950cshung wants to merge 1 commit intodotnet:mainfrom
cshung wants to merge 1 commit intodotnet:mainfrom
Conversation
…d with allocation
|
Tagging subscribers to this area: @dotnet/gc |
Contributor
Author
|
Here is the result of running I didn't trust the data at first and therefore I ran it 30 times to eliminate random fluctuations. |
Contributor
Author
|
Contributor
Author
|
Please ignore the current fix. @Maoni0 and I were thinking about an alternative fix that does not involve additional synchronization. |
Member
|
// Auto-generated message 69e114c which was merged 12/7 removed the intermediate src/coreclr/src/ folder. This PR needs to be updated as it touches files in that directory which causes conflicts. To update your commits you can use this bash script: https://gist.github.com/ViktorHofer/6d24f62abdcddb518b4966ead5ef3783. Feel free to use the comment section of the gist to improve the script for others. |
Member
|
@cshung we discussed this yesterday, please consider closing since its not been updated for a few months and possibly create an issue if this still needs fixing. |
Member
|
@cshung is this PR still relevant? If you still need to keep it, we could close and reopen when you are ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #35896,
decommit_heap_segment_pagescould be called outside of the GC pause. This function modifiesheap_segment.used, which is also read byadjust_limit_clr, called by allocation.Before the change, these operations are not synchronized, leading to the possibility of a race condition.